Skip to content

Conversation

@greglixandrao
Copy link
Contributor

We need to change the oracle logo for SP 2025 event

@greglixandrao greglixandrao requested a review from a team as a code owner November 5, 2025 14:50
@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for devopsdays-web ready!

Name Link
🔨 Latest commit 75e4c1f
🔍 Latest deploy log https://app.netlify.com/projects/devopsdays-web/deploys/6911beb5077c080008410264
😎 Deploy Preview https://deploy-preview-15572--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@greglixandrao
Copy link
Contributor Author

Hello revisors!
Can anyone review this PR?

Thank you.

@phrawzty
Copy link
Collaborator

👋 This touches a lot of files in 2016-london that seem sort of weird. We'll need a moment to see what the impact is there.

@greglixandrao
Copy link
Contributor Author

👋 This touches a lot of files in 2016-london that seem sort of weird. We'll need a moment to see what the impact is there.

Hello, thank you for feedback.
I just change a logo with the script "change_sponsor_logo.sh" thas why it touches in a lot of files.

If you need more information, get in touch!

@phrawzty
Copy link
Collaborator

phrawzty commented Nov 10, 2025

OK so upon further inspection, the touches to the old London event aren't a problem, however you've revealed a bug in the change_sponsor_logo.sh script that has created some errant outcomes.

You only wanted to change the logo for sponsor oracle (i.e. assets/sponsors/o/oracle.png), however the script matched all instances of string oracle, so it also touched oracle-linux and oraclecloud, with some weird outcomes:

image

As a result, this PR can't be merged, even though it's not your fault—the script is buggy. We'll need to fix the bug with the script first, then you can run it an open a new PR once the bug is dealt with.

@greglixandrao
Copy link
Contributor Author

OK so upon further inspection, the touches to the old London event aren't a problem, however you've revealed a bug in the change_sponsor_logo.sh script that has created some errant outcomes.

You only wanted to change the logo for sponsor oracle (i.e. assets/sponsors/o/oracle.png), however the script matched all instances of string oracle, so it also touched oracle-linux and oraclecloud, with some weird outcomes:

image As a result, this PR can't be merged, even though it's not your fault—the script is buggy. We'll need to fix the bug with the script first, then you can run it an open a new PR once the bug is dealt with.

@phrawzty Thank you for explanation!

I will close this PR and I'm going to manually change the logo since the sponsor is demanding that the correct logo be released.

Thank's again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants